repo/luan: src/org/eclipse/jetty/http/HttpFields.java comparison

comparison src/org/eclipse/jetty/http/HttpFields.java @ 1020:6be43ef1eb96

HttpHeaderValues uses StringCache

author	Franklin Schmidt <fschmidt@gmail.com>
date	Mon, 31 Oct 2016 22:24:41 -0600
parents	f126d30e04a4
children	e350c11242be

comparison

equal deleted inserted replaced

-:f126d30e04a4
+:6be43ef1eb96
 	private final ArrayList<Field> _fields = new ArrayList<Field>(20);
 	private final HashMap<Buffer,Field> _names = new HashMap<Buffer,Field>(32);
+/*
-	/* ------------------------------------------------------------ */
-	/**
-	 * Constructor.
-	 */
-	public HttpFields()
-	{
-	}
-	// TODO externalize this cache so it can be configurable
-	private static ConcurrentMap<String, Buffer> __cache = new ConcurrentHashMap<String, Buffer>();
-	private static int __cacheSize = Integer.getInteger("org.eclipse.jetty.http.HttpFields.CACHE",2000);
-	/* -------------------------------------------------------------- */
 	private Buffer convertValue(String value)
 	{
-		Buffer buffer = __cache.get(value);
-		if (buffer!=null)
-			return buffer;
 		try
 		{
-			buffer = new ByteArrayBuffer(value,StringUtil.__ISO_8859_1);
+			return new ByteArrayBuffer(value,StringUtil.__ISO_8859_1);
-			if (__cacheSize>0)
-			{
-				if (__cache.size()>__cacheSize)
-					__cache.clear();
-				Buffer b=__cache.putIfAbsent(value,buffer);
-				if (b!=null)
-					buffer=b;
-			}
-			return buffer;
 		}
 		catch (UnsupportedEncodingException e)
 		{
 			throw new RuntimeException(e);
 		}
 	}
+*/
 	/* -------------------------------------------------------------- */
 	/**
 	 * Get Collection of header names.
 	 */
 		return field==null?null:field.getValue();
 	}
 	/* -------------------------------------------------------------- */
 	/**
-	 * @return the value of a field, or null if not found. For multiple fields of the same name,
-	 *         only the first is returned.
-	 * @param name the case-insensitive field name
-	 */
-	public Buffer get(Buffer name)
-	{
-		Field field = getField(name);
-		return field==null?null:field._value;
-	}
-	/* -------------------------------------------------------------- */
-	/**
 	 * Get multi headers
 	 *
 	 * @return Enumeration of the values, or null if no such header.
 	 * @param name the case-insensitive field name
 	 */
 	public Collection<String> getValuesCollection(String name)
 	{
 		Field field = getField(name);
-	if (field==null)
+		if (field==null)
-		return null;
+			return null;
-		final List<String> list = new ArrayList<String>();
+			final List<String> list = new ArrayList<String>();
-	while(field!=null)
+		while(field!=null)
-	{
+		{
-		list.add(field.getValue());
+			list.add(field.getValue());
-		field=field._next;
+			field=field._next;
-	}
+		}
-	return list;
+		return list;
 	}
 	/* -------------------------------------------------------------- */
 	/**
 	 * Get multi headers
 		if (value==null)
 			remove(name);
 		else
 		{
 			Buffer n = HttpHeaders.CACHE.lookup(name);
-			Buffer v = convertValue(value);
+			put(n, value);
-			put(n, v);
 		}
 	}
 	/* -------------------------------------------------------------- */
 	/**
 	 * @param name the name of the field
 	 * @param value the value of the field. If null the field is cleared.
 	 */
 	public void put(Buffer name, String value)
 	{
+/*
 		Buffer n = HttpHeaders.CACHE.lookup(name);
 		Buffer v = convertValue(value);
 		put(n, v);
-	}
+*/
-	/* -------------------------------------------------------------- */
-	/**
-	 * Set a field.
-	 *
-	 * @param name the name of the field
-	 * @param value the value of the field. If null the field is cleared.
-	 */
-	public void put(Buffer name, Buffer value)
-	{
 		remove(name);
 		if (value == null)
 			return;
 		if (!(name instanceof BufferCache.CachedBuffer))
 			name = HttpHeaders.CACHE.lookup(name);
+		int valueOrdinal = HttpHeaderValues.CACHE.getOrdinal(value);
+		// new value;
+		Field field = new Field(name, value, valueOrdinal);
+		_fields.add(field);
+		_names.put(name, field);
+	}
+	/* -------------------------------------------------------------- */
+	/**
+	 * Set a field.
+	 *
+	 * @param name the name of the field
+	 * @param value the value of the field. If null the field is cleared.
+	 */
+	public void put(Buffer name, Buffer value)
+	{
+/*
+		remove(name);
+		if (value == null)
+			return;
+		if (!(name instanceof BufferCache.CachedBuffer))
+			name = HttpHeaders.CACHE.lookup(name);
 		if (!(value instanceof CachedBuffer))
-			value= HttpHeaderValues.CACHE.lookup(value).asImmutableBuffer();
+			value = HttpHeaderValues.CACHE.lookup(value).asImmutableBuffer();
 		// new value;
 		Field field = new Field(name, value);
 		_fields.add(field);
 		_names.put(name, field);
-	}
+*/
+		String s = value==null ? null : value.toString();
-	/* -------------------------------------------------------------- */
+		put(name,s);
-	/**
-	 * Set a field.
-	 *
-	 * @param name the name of the field
-	 * @param list the List value of the field. If null the field is cleared.
-	 */
-	public void put(String name, List<?> list)
-	{
-		if (list == null || list.size() == 0)
-		{
-			remove(name);
-			return;
-		}
-		Buffer n = HttpHeaders.CACHE.lookup(name);
-		Object v = list.get(0);
-		if (v != null)
-			put(n, HttpHeaderValues.CACHE.lookup(v.toString()));
-		else
-			remove(n);
-		if (list.size() > 1)
-		{
-			java.util.Iterator<?> iter = list.iterator();
-			iter.next();
-			while (iter.hasNext())
-			{
-				v = iter.next();
-				if (v != null) put(n, HttpHeaderValues.CACHE.lookup(v.toString()));
-			}
-		}
 	}
 	/* -------------------------------------------------------------- */
 	/**
 	 * Add to or set a field. If the field is allowed to have multiple values, add will add multiple
 	public void add(String name, String value) throws IllegalArgumentException
 	{
 		if (value==null)
 			return;
 		Buffer n = HttpHeaders.CACHE.lookup(name);
-		Buffer v = convertValue(value);
+		add(n, value);
-		add(n, v);
 	}
 	/* -------------------------------------------------------------- */
 	/**
 	 * Add to or set a field. If the field is allowed to have multiple values, add will add multiple
 	 * @param name the name of the field
 	 * @param value the value of the field.
 	 * @exception IllegalArgumentException If the name is a single valued field and already has a
 	 *                value.
 	 */
-	public void add(Buffer name, Buffer value) throws IllegalArgumentException
+	public void add(Buffer name, String value) throws IllegalArgumentException
 	{
 		if (value == null) throw new IllegalArgumentException("null value");
 		if (!(name instanceof CachedBuffer))
 			name = HttpHeaders.CACHE.lookup(name);
 		name=name.asImmutableBuffer();
+/*
 		if (!(value instanceof CachedBuffer) && HttpHeaderValues.hasKnownValues(HttpHeaders.CACHE.getOrdinal(name)))
 			value= HttpHeaderValues.CACHE.lookup(value);
 		value=value.asImmutableBuffer();
+*/
 		Field field = _names.get(name);
 		Field last = null;
 		while (field != null)
 		{
 			last = field;
 			field = field._next;
 		}
 		// create the field
-		field = new Field(name, value);
+		int valueOrdinal = HttpHeaderValues.CACHE.getOrdinal(value);
+		field = new Field(name, value, valueOrdinal);
 		_fields.add(field);
 		// look for chain to add too
 		if (last != null)
 			last._next = field;
 	{
 		Field field = getField(name);
 		if (field == null)
 			return -1;
-		String val = valueParameters(BufferUtil.to8859_1_String(field._value), null);
+		String val = valueParameters(field._value, null);
 		if (val == null)
 			return -1;
 		final long date = __dateParser.get().parse(val);
 		if (date==-1)
 	 * @param name the field name
 	 * @param value the field long value
 	 */
 	public void putLongField(Buffer name, long value)
 	{
-		Buffer v = BufferUtil.toBuffer(value);
+//		Buffer v = BufferUtil.toBuffer(value);
+		String v = Long.toString(value);
 		put(name, v);
 	}
 	/* -------------------------------------------------------------- */
 	/**
 	 * @param value the field long value
 	 */
 	public void putLongField(String name, long value)
 	{
 		Buffer n = HttpHeaders.CACHE.lookup(name);
-		Buffer v = BufferUtil.toBuffer(value);
+//		Buffer v = BufferUtil.toBuffer(value);
+		String v = Long.toString(value);
 		put(n, v);
 	}
 	/* -------------------------------------------------------------- */
 	/**
 	 * @param value the field long value
 	 */
 	public void addLongField(String name, long value)
 	{
 		Buffer n = HttpHeaders.CACHE.lookup(name);
-		Buffer v = BufferUtil.toBuffer(value);
+//		Buffer v = BufferUtil.toBuffer(value);
+		String v = Long.toString(value);
 		add(n, v);
 	}
 	/* -------------------------------------------------------------- */
 	/**
 	 * @param name the field name
 	 * @param value the field long value
 	 */
 	public void addLongField(Buffer name, long value)
 	{
-		Buffer v = BufferUtil.toBuffer(value);
+//		Buffer v = BufferUtil.toBuffer(value);
+		String v = Long.toString(value);
 		add(name, v);
 	}
 	/* -------------------------------------------------------------- */
 	/**
 	 */
 	public void addDateField(String name, long date)
 	{
 		String d=formatDate(date);
 		Buffer n = HttpHeaders.CACHE.lookup(name);
-		Buffer v = new ByteArrayBuffer(d);
+//		Buffer v = new ByteArrayBuffer(d);
-		add(n, v);
+		add(n, d);
 	}
 	/* ------------------------------------------------------------ */
 	/**
 	 * Format a set cookie value
 			}
 			last=field;
 			field=field._next;
 		}
-		add(HttpHeaders.SET_COOKIE_BUFFER, new ByteArrayBuffer(name_value_params));
+		add(HttpHeaders.SET_COOKIE_BUFFER, name_value_params);
 		// Expire responses with set-cookie headers so they do not get cached.
 		put(HttpHeaders.EXPIRES_BUFFER, __01Jan1970_BUFFER);
 	}
-	/* -------------------------------------------------------------- */
+	@Override
-	public void putTo(Buffer buffer) throws IOException
-	{
-		for (int i = 0; i < _fields.size(); i++)
-		{
-			Field field = _fields.get(i);
-			if (field != null)
-				field.putTo(buffer);
-		}
-		BufferUtil.putCRLF(buffer);
-	}
-	/* -------------------------------------------------------------- */
 	public String toString()
 	{
 		try
 		{
 			StringBuffer buffer = new StringBuffer();
 		}
 		ql.clear();
 		return vl;
 	}
-	/* ------------------------------------------------------------ */
-	/* ------------------------------------------------------------ */
-	/* ------------------------------------------------------------ */
 	public static final class Field
 	{
-		private Buffer _name;
+		private final Buffer _name;
-		private Buffer _value;
+		private final String _value;
+		private final int _valueOrdinal;
 		private Field _next;
-		/* ------------------------------------------------------------ */
+		private Field(Buffer name, String value, int valueOrdinal)
-		private Field(Buffer name, Buffer value)
 		{
 			_name = name;
 			_value = value;
+			_valueOrdinal = valueOrdinal;
 			_next = null;
 		}
+/*
-		/* ------------------------------------------------------------ */
+		private Field(Buffer name, Buffer value)
+		{
+			this(name,value.toString(),HttpHeaderValues.CACHE.getOrdinal(value));
+		}
+*/
 		public void putTo(Buffer buffer) throws IOException
 		{
 			int o=(_name instanceof CachedBuffer)?((CachedBuffer)_name).getOrdinal():-1;
 			if (o>=0)
 				buffer.put(_name);
 			}
 			buffer.put((byte) ':');
 			buffer.put((byte) ' ');
-			o=(_value instanceof CachedBuffer)?((CachedBuffer)_value).getOrdinal():-1;
+			o = _valueOrdinal;
+			byte[] valueBytes = StringUtil.getBytes(_value);
 			if (o>=0)
-				buffer.put(_value);
+				buffer.put(valueBytes);
 			else
 			{
-				int s=_value.getIndex();
+				for( byte b : valueBytes ) {
-				int e=_value.putIndex();
-				while (s<e)
-				{
-					byte b=_value.peek(s++);
 					switch(b)
 					{
 						case '\r':
 						case '\n':
 							continue;
 			}
 			BufferUtil.putCRLF(buffer);
 		}
-		/* ------------------------------------------------------------ */
+		private String getName()
-		public String getName()
 		{
 			return BufferUtil.to8859_1_String(_name);
 		}
-		/* ------------------------------------------------------------ */
-		Buffer getNameBuffer()
-		{
-			return _name;
-		}
-		/* ------------------------------------------------------------ */
 		public int getNameOrdinal()
 		{
 			return HttpHeaders.CACHE.getOrdinal(_name);
 		}
-		/* ------------------------------------------------------------ */
 		public String getValue()
 		{
-			return BufferUtil.to8859_1_String(_value);
-		}
-		/* ------------------------------------------------------------ */
-		public Buffer getValueBuffer()
-		{
 			return _value;
 		}
-		/* ------------------------------------------------------------ */
 		public int getValueOrdinal()
 		{
-			return HttpHeaderValues.CACHE.getOrdinal(_value);
+			return _valueOrdinal;
 		}
-		/* ------------------------------------------------------------ */
 		public int getIntValue()
 		{
 			return (int) getLongValue();
 		}
-		/* ------------------------------------------------------------ */
 		public long getLongValue()
 		{
 			return BufferUtil.toLong(_value);
 		}
-		/* ------------------------------------------------------------ */
+		@Override
 		public String toString()
 		{
 			return ("[" + getName() + "=" + _value + (_next == null ? "" : "->") + "]");
 		}
 	}

Mercurial Hosting > luan

comparison src/org/eclipse/jetty/http/HttpFields.java @ 1020:6be43ef1eb96